Update XDR definitions to Protocol 14. #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abuiles
commented
Sep 21, 2020
types/xdr.d.ts
Outdated
| | 'pathPaymentStrictSend' | ||
| | 'createClaimableBalance' | ||
| | 'claimClaimableBalance' | ||
| | 'beginSponsoringFutureReserf' |
There was a problem hiding this comment.
oh -- this is weird, it should say beingSponsoringFutureReserves -- I'll check what's going on
morleyzhi
reviewed
Sep 21, 2020
| @@ -235,7 +235,7 @@ export class Operation { | |||
| result.destination = encodeMuxedAccountToAddress(attrs); | |||
| break; | |||
| } | |||
| case 'manageDatum': { | |||
| case 'manageData': { | |||
There was a problem hiding this comment.
These changes seem like they'll break old code; is that change documented anywhere? Is there a way to make this backwards-compatible?
There was a problem hiding this comment.
@morleyzhi People who rely on stellar-base and the helper we expose, won't have any problem since the change is transparent for them.
However, if someone is using the autogenerated code for the XDR library and it's relying on this, it's very likely their code will break. I'll update the changelog to reflect this change.
morleyzhi
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regenerate XDR definitions with Protocol 14.
This includes the new operations from CAP23 and CAP33.
The XDR generated in this code includes breaking changes on the internal XDR library since a bug was fixed which was causing incorrect code to be generated (see stellar/xdrgen#52)
The following functions were renamed:
xdr.OperationBody.setOption()->xdr.OperationBody.setOptions()xdr.OperationBody.manageDatum()->xdr.OperationBody.manageData()xdr.OperationType.setOption()->xdr.OperationType.setOptions()xdr.OperationType.manageDatum()->xdr.OperationType.manageData()